Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code paths for python <3.11 #9445

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Remove code paths for python <3.11 #9445

merged 1 commit into from
Dec 10, 2024

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Dec 4, 2024 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@JHolba JHolba self-assigned this Dec 4, 2024
@JHolba JHolba added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (0ba0626) to head (2467479).
Report is 70 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9445      +/-   ##
==========================================
+ Coverage   91.86%   91.87%   +0.01%     
==========================================
  Files         433      433              
  Lines       26657    26736      +79     
==========================================
+ Hits        24488    24564      +76     
- Misses       2169     2172       +3
Flag Coverage Δ
cli-tests 39.37% <80.00%> (-0.05%) ⬇️
everest-models-test 34.73% <81.25%> (-0.10%) ⬇️
gui-tests 72.14% <93.33%> (-0.20%) ⬇️
integration-test 37.03% <81.25%> (-0.13%) ⬇️
performance-tests 51.91% <100.00%> (-0.18%) ⬇️
test 40.68% <81.25%> (+0.16%) ⬆️
unit-tests 74.06% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq jonathan-eq self-requested a review December 5, 2024 13:00
eivindjahren
eivindjahren approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

eivindjahren
eivindjahren requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut out a bit too much.

@JHolba
Copy link
Contributor Author

JHolba commented Dec 9, 2024

Cut out a bit too much.

Urgh. Brainfart. Will fix

@JHolba JHolba force-pushed the remove-conditional-version-code branch from 89c55a3 to 2467479 Compare December 10, 2024 09:19
eivindjahren
eivindjahren approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@JHolba JHolba merged commit 4efb190 into equinor:main Dec 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindjahren eivindjahren eivindjahren approved these changes

@jonathan-eq jonathan-eq Awaiting requested review from jonathan-eq

Assignees

@JHolba JHolba

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JHolba @codecov-commenter @eivindjahren